Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: adjust logic in testPodClusterRoleBindings #1792

Conversation

jmontesi
Copy link
Contributor

@jmontesi jmontesi commented Jan 9, 2024

The code of this test case might have mixed up with the merge of main and ginkgo_removal branches.

@jmontesi jmontesi requested review from edcdavid and greyerof January 9, 2024 11:24
@greyerof
Copy link
Contributor

greyerof commented Jan 9, 2024

My fault. @edcdavid updated that test case in PR #1646 but somehow I ended up reverting some of the changes when rebasing the ginkgo_removal branch with main...

@edcdavid can you review this, please?

@jmontesi jmontesi merged commit f1968dd into redhat-best-practices-for-k8s:main Jan 10, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants